[VAN-929] improve performance of bucket interpreter (#82)

* Add interpreter functions for non-modifying buckets. This allows certain buckets to be interpreted without first cloning the Env object.
* Remove additional Env clones
* Remove unused functions from Env
* Use bucket ID instead of cloning buckets for map key in unknown index sanitizer

circuit_passes/src/bucket_interpreter/env/extracted_func_env.rs

@@ -1,5 +1,5 @@
 use std::cell::Ref;
-use std::collections::{HashMap, BTreeMap, HashSet};
+use std::collections::{BTreeMap, HashSet};
 use std::fmt::{Display, Formatter};
 use compiler::circuit_design::function::FunctionCode;
 use compiler::circuit_design::template::TemplateCode;
@@ -251,10 +251,6 @@ impl<'a> ExtractedFuncEnvData<'a> {
         res
     }
 
-    pub fn get_vars_clone(&self) -> HashMap<usize, Value> {
-        self.base.get_vars_clone()
-    }
-
     pub fn get_vars_sort(&self) -> BTreeMap<usize, Value> {
         self.base.get_vars_sort()
     }

circuit_passes/src/bucket_interpreter/env/mod.rs

@@ -211,14 +211,6 @@ impl<'a> Env<'a> {
         }
     }
 
-    pub fn get_vars_clone(&self) -> HashMap<usize, Value> {
-        match self {
-            Env::Standard(d) => d.get_vars_clone(),
-            Env::UnrolledBlock(d) => d.get_vars_clone(),
-            Env::ExtractedFunction(d) => d.get_vars_clone(),
-        }
-    }
-
     pub fn get_vars_sort(&self) -> BTreeMap<usize, Value> {
         match self {
             Env::Standard(d) => d.get_vars_sort(),

circuit_passes/src/bucket_interpreter/env/standard_env.rs

@@ -84,10 +84,6 @@ impl<'a> StandardEnvData<'a> {
         self.subcmps.get(&subcmp_idx).unwrap().counter_equal_to(value)
     }
 
-    pub fn get_vars_clone(&self) -> HashMap<usize, Value> {
-        self.vars.clone()
-    }
-
     pub fn get_vars_sort(&self) -> BTreeMap<usize, Value> {
         self.vars.iter().fold(BTreeMap::new(), |mut acc, e| {
             acc.insert(*e.0, e.1.clone());

circuit_passes/src/bucket_interpreter/env/unrolled_block_env.rs

@@ -1,5 +1,5 @@
 use std::cell::Ref;
-use std::collections::{HashMap, BTreeMap};
+use std::collections::BTreeMap;
 use std::fmt::{Display, Formatter};
 use compiler::circuit_design::function::FunctionCode;
 use compiler::circuit_design::template::TemplateCode;
@@ -94,10 +94,6 @@ impl<'a> UnrolledBlockEnvData<'a> {
         self.base.subcmp_counter_equal_to(subcmp_idx, value)
     }
 
-    pub fn get_vars_clone(&self) -> HashMap<usize, Value> {
-        self.base.get_vars_clone()
-    }
-
     pub fn get_vars_sort(&self) -> BTreeMap<usize, Value> {
         self.base.get_vars_sort()
     }