[IMP] internal_transfer_with_agreed_amount: modify write vals in one method i#24002 #1631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLaurelB
force-pushed
the
16.0-set_all_lines_vals_in_one_method-CLaurelB
branch
2 times, most recently
from
2cd1258 to
3e8fc96
Compare
|
@rolandojduartem could you review, please? |
| vals = {"debit": line.debit} if line.amount_currency > 0 else {"credit": line.credit} | ||
| sign = 1 if line.amount_currency > 0 else -1 | ||
| vals.update({"amount_currency": sign * self.agreed_amount, "currency_id": currency.id}) | ||
| return vals | ||
|
|
||
| def _postprocessing_payment_with_aggred_amount(self, payment): |
There was a problem hiding this comment.
Suggested change
| def _postprocessing_payment_with_aggred_amount(self, payment): | |
| def _postprocessing_payment_with_agreed_amount(self, payment): |
| vals = self._prepare_values_from_lines(debit, is_same_company_currency=True) | ||
| debit.with_context(check_move_validity=False).write(vals) | ||
| vals = self._prepare_values_from_lines(credit, is_same_company_currency=True) | ||
| credit.with_context(check_move_validity=False).write(vals) | ||
| amls.move_id.action_post() | ||
| to_reconcile.reconcile() | ||
| return |
There was a problem hiding this comment.
Sorry, you have to call the method before the return too self._postprocessing_payment_with_agreed_amount(payment)
CLaurelB
force-pushed
the
16.0-set_all_lines_vals_in_one_method-CLaurelB
branch
from
3e8fc96 to
f08b8d4
Compare
|
@rolandojduartem could you review again, please? |
CLaurelB
force-pushed
the
16.0-set_all_lines_vals_in_one_method-CLaurelB
branch
3 times, most recently
from
0782a2b to
207c450
Compare
rolandojduartem
approved these changes
Nov 3, 2023
luisg123v
requested changes
Nov 4, 2023
internal_transfer_with_agreed_amount/wizards/internal_transfer_multicurrency.py
Outdated
Show resolved
Hide resolved
internal_transfer_with_agreed_amount/wizards/internal_transfer_multicurrency.py
Outdated
Show resolved
Hide resolved
|
Missing task ID on MR title |
CLaurelB
force-pushed
the
16.0-set_all_lines_vals_in_one_method-CLaurelB
branch
from
207c450 to
79e19c7
Compare
CLaurelB
changed the title
Since it's related to a ticket, I added the ticket ID on the title. |
|
@luisg123v could you review again, please? |
CLaurelB
force-pushed
the
16.0-set_all_lines_vals_in_one_method-CLaurelB
branch
from
79e19c7 to
c88971d
Compare
…method Modify in a single method the values that will be written in the account move lines so that the method can be inherited in case it is necessary to modify more values in the lines. In addition, two methods are added to pre and post process payments, to be used if modifications are required in an inheritance. Finally, obtaining currencies related to the internal transfer have been moved to a separate method to facilitate the inheritance of the method that validates the number of currencies. Changelog: - Set debit and credit values to write in _prepare_values_from_lines method when the exchange currency is the same as the company currency. - Add methods to be inherited when payments also needs modifications. - Get the currencies in a new method named _get_currencies.
CLaurelB
force-pushed
the
16.0-set_all_lines_vals_in_one_method-CLaurelB
branch
from
c88971d to
7bda48e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify in a single method the values that will be written in the account
move lines so that the method can be inherited in case it is necessary
to modify more values in the lines.
In addition, two methods are added to pre and post process payments, to
be used if modifications are required in an inheritance.
Finally, obtaining currencies related to the internal transfer have been
moved to a separate method to facilitate the inheritance of the method
that validates the number of currencies.
Changelog:
method when the exchange currency is the same as the company currency.