Remove log warning for known cases of wrong FW strings

Vaskivskyi · Sep 14, 2024 · 0449b42 · 0449b42
1 parent 4d6b5c8
commit 0449b42
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/asusrouter/modules/firmware.py b/asusrouter/modules/firmware.py
@@ -140,7 +140,11 @@ def from_string(self, fw_string: Optional[str] = None) -> None:
 
         fw_string = clean_string(fw_string)
         if not fw_string:
-            return
+            return None
+
+        # Special cases for old firmwares and absent data
+        if fw_string == "__":
+            return None
 
         pattern = (
             r"^(?P<major>[39].?0.?0.?[46])?[_.]?"

diff --git a/tests/modules/test_firmware.py b/tests/modules/test_firmware.py
@@ -161,6 +161,7 @@ def test_update_source(self, revision, expected_source):
             ),
             # Additional cases
             (".386.7_120", None, 386, 7, 120, False, False),
+            ("__", None, None, None, None, False, False),
             # Invalid input
             ("", None, None, None, None, False, False),
             ("invalid", None, None, None, None, False, False),