Skip to content
This repository has been archived by the owner on Jul 30, 2021. It is now read-only.

Read configuration from validic.yml - railtie approach #44

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amf9t2
Copy link

@amf9t2 amf9t2 commented Sep 29, 2016

Providing an option to consumer to declare configuration in validic yml so that they can maintain different validic token with respect to their environments.

read configuration from validic yml

read configuration from validic yml

PORTALDEV-29878_railtie_validic_changes adding changes to load gem conf via rail tie

PORTALDEV-29878_railtie_validic_changes keeping original logic in place

PORTALDEV-29878_railtie_validic_changes updating read me to inform user about yml file as an option

updating read me

highlighter changes
@alex-bezek
Copy link

@allcentury , concerning this issue I opened #36
were you leaning more towards creating a validic-rails gem that just requires validic as a dependency and initializes it, or were you ok with using this approach that only requires the railtie file if ::Rails.defined? to not couple the gem to rails specifically? If your ok with this strategy, I'll go through and code review my teammates pull request.

Thanks,
Alex Bezek

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants