Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint, es6-7, JS Promise, useEffect #1

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

JessicaHoang
Copy link

  • made sure to install eslint
  • set es version to es6-7
  • made tickerService async function return a promise to be accessed in app.js
  • app.js is now using useEffect and useState to try and display the data on the frontend.Z
  • a few errors on the frontend, so not yet deployable

- made sure to install eslint
- set es version to es6-7
- made tickerService async function return a promise to be accessed in app.js
- app.js is now using useEffect and useState to try and display the data on the frontend.Z
- a few errors on the frontend, so not yet deployable
Copy link
Author

@JessicaHoang JessicaHoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code needs to be refactored.

Copy link
Author

@JessicaHoang JessicaHoang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot of necessary changes, but need to be refactored to properly display clientside app.

- fixed server side, so it's emitting as expected.
- tickerService returns a Promise
- App.js  currently does not accept and update data. stockData is returning Null.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant