Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix types #1288

Merged
merged 1 commit into from
Jan 20, 2025
Merged

fix types #1288

merged 1 commit into from
Jan 20, 2025

Conversation

edsilv
Copy link
Member

@edsilv edsilv commented Jan 20, 2025

expose ContentType type, make extension undefined instead of null, don't export URLAdapter twice.

@edsilv edsilv requested a review from demiankatz January 20, 2025 15:30
@vercel Vercel
Copy link

vercel bot commented Jan 20, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
universalviewer ✅ Ready (Inspect) Visit Preview Jan 20, 2025 3:30pm

demiankatz
demiankatz approved these changes Jan 20, 2025
View reviewed changes
Copy link
Contributor

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. @LanieOkorodudu, do you mind running your tests against this as well? I don't think these fixes are big enough to require a whole new RC, but if we're going to merge them into the final 4.1.0 release, it would be good to ensure no tests are broken by them (though I fully expect everything to pass).

@LanieOkorodudu
Copy link
Collaborator

Looks good to me. @LanieOkorodudu, do you mind running your tests against this as well? I don't think these fixes are big enough to require a whole new RC, but if we're going to merge them into the final 4.1.0 release, it would be good to ensure no tests are broken by them (though I fully expect everything to pass).

@demiankatz, sure.

LanieOkorodudu
LanieOkorodudu approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@LanieOkorodudu LanieOkorodudu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@demiankatz , I have tested the fix, and it works as expected. All tests pass, and everything looks good to merge.

@demiankatz demiankatz merged commit 3ec353a into release-4.1.0 Jan 20, 2025
4 checks passed
@demiankatz demiankatz deleted the feature/fix-types branch January 20, 2025 16:16
@demiankatz demiankatz mentioned this pull request Jan 21, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LanieOkorodudu LanieOkorodudu LanieOkorodudu approved these changes

@demiankatz demiankatz demiankatz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edsilv @LanieOkorodudu @demiankatz