rename _contentType and _assignedContentHandler to remove leading underscore #1271
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
edsilv
changed the title
There was a problem hiding this comment.
@edsilv, the changes here look reasonable to me, but the Vercel build is failing. I don't have access to see the logs. Is this PR somehow breaking something, or is Vercel just having unrelated problems?
|
It looks like that problem with Puppeteer again? |
Very strange. Why is it failing here when the build passes on other PRs? Where do we need to go to disable running the test suite on Vercel builds? Since it runs successfully in GitHub Actions, I think we can safely skip it for Vercel if that will stop these intermittent problems. Perhaps a topic we can discuss on today's Steering Group call, if you're able to make it and time permits. |
|
closing this as have created a new pr here that seems to be ok: #1282 |
renamed
_contentTypeand_assignedContentHandlerto remove leading underscore. set them to public.this is because I use them in Exhibit (they're useful), and have noticed them used elsewhere.
Description of what you did: