Skip to content

Commit

Permalink
Fix/cleanup clear selection after ignore/display issues (#57)
Browse files Browse the repository at this point in the history
  • Loading branch information
Marco Trivellato authored and GitHub Enterprise committed Aug 21, 2023
1 parent f369b6c commit 49c767e
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 2 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
* Upgrade com.unity.nuget.mono-cecil to 1.11.4
* Visualization of the Horizontal Stacked Bar and Legend Item
* Improved AudioClip asset table
* Clear table selection on unmuting issues

### Removed
* Actions section and Mute/Unmute buttons
Expand Down
4 changes: 4 additions & 0 deletions Editor/UI/Framework/DiagnosticView.cs
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,8 @@ public override void DrawDetails(ProjectIssue[] selectedIssues)
}

m_ViewManager.onDisplayIssues?.Invoke(selectedIssues);

ClearSelection();
});
}
else
Expand All @@ -147,6 +149,8 @@ public override void DrawDetails(ProjectIssue[] selectedIssues)
}

m_ViewManager.onIgnoreIssues?.Invoke(selectedIssues);

ClearSelection();
});
}
}
Expand Down
2 changes: 0 additions & 2 deletions Editor/UI/ProjectAuditorWindow.cs
Original file line number Diff line number Diff line change
Expand Up @@ -304,8 +304,6 @@ void InitializeViews(IssueCategory[] categories, bool reload)
{
var analytic = ProjectAuditorAnalytics.BeginAnalytic();

activeView.ClearSelection();

ProjectAuditorAnalytics.SendEventWithSelectionSummary(ProjectAuditorAnalytics.UIButton.Mute,
analytic, issues);
};
Expand Down

0 comments on commit 49c767e

Please sign in to comment.