Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Acknowledge Apereo Welcoming Policy. #29

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

apetro
Copy link

@apetro apetro commented Jun 30, 2017

No description provided.

Copy link
Contributor

@tomas-muller tomas-muller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the pull request.

I think, for now, it would be better to put the link to the Apereo Welcoming Policy into the CODE_OF_CONDUCT.md (as proposed), but do not create the CONTRIBUTING.md as we do not have one created yet.

It is on my todo list to write a CONTRIBUTING.md document (so far there has not been much need for it as the number of outside contributions we are getting is minimal and we get directly involved with all of them). I will include the link to the Apereo Welcoming Policy when I write it.

@@ -0,0 +1,7 @@
# Contributing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why .github/CONTRIBUTING.md (especially the .github location)?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tucking CONTRIBUTING.md into the .github/ directory reduces bulk, noise in the project root directory. It's a way to navigate the tradeoffs in starting to have a CONTRIBUTING.md without yet having fully written one.

GitHub will use CONTRIBUTING.md in either location. If GitHub finds a CONTRIBUTING.md it will draw attention to it in the Pull Request authoring UI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants