Edit Instructor: Position

- it is now possible to reset the instructor's position
UniTime · Oct 25, 2023 · e85f1ce · e85f1ce
1 parent 90efaad
commit e85f1ce
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 1 deletion.
diff --git a/JavaSource/org/unitime/timetable/action/InstructorAction.java b/JavaSource/org/unitime/timetable/action/InstructorAction.java
@@ -209,6 +209,8 @@ protected void doUpdate() throws Exception {
 				if (pt != null) {
 					inst.setPositionType(pt);
 				}
+			} else {
+				inst.setPositionType(null);
 			}
 
 			if (form.getNote() != null && !form.getNote().isEmpty()) {

diff --git a/WebContent/help/Release-Notes.xml b/WebContent/help/Release-Notes.xml
@@ -35,6 +35,12 @@
 				<line>Added an ability for departmental schedule managers to unsubmit the survey directly from the Instructor Survey page/dialog (meaning save and unsubmit).</line>
 			</description>
 		</item>
+		<item>
+			<name>Edit Instructor</name>
+			<description>
+				<line>It is now possible to reset the instructor's position.</line>
+			</description>
+		</item>
 	</category>
 	<category>
 		<title>Batch Student Scheduling</title>

diff --git a/WebContent/user/instructor.jspf b/WebContent/user/instructor.jspf
@@ -132,7 +132,7 @@
 		<TR>
 			<TD><loc:message name="propertyInstructorPosition"/></TD>
 			<TD>
-				<s:select name="form.posType" list="#request.posTypeList" listKey="uniqueId" listValue="label" headerKey="" headerValue="%{#const.select()}"></s:select>
+				<s:select name="form.posType" list="#request.posTypeList" listKey="uniqueId" listValue="label" headerKey="" headerValue="%{#msg.valueNotSet()}"></s:select>
 			</TD>
 		</TR>
 	</s:if>
-Original file line number
+Diff line change
@@ Expand Up / @@ -132,7 +132,7 @@ @@
     		<TR>
     			<TD><loc:message name="propertyInstructorPosition"/></TD>
     			<TD>
-    				<s:select name="form.posType" list="#request.posTypeList" listKey="uniqueId" listValue="label" headerKey="" headerValue="%{#const.select()}"></s:select>
+    				<s:select name="form.posType" list="#request.posTypeList" listKey="uniqueId" listValue="label" headerKey="" headerValue="%{#msg.valueNotSet()}"></s:select>
     			</TD>
     		</TR>
     	</s:if>
@@ Expand Down @@