Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

producer: Add context.Context #1

Closed
wants to merge 2 commits into from
Closed

producer: Add context.Context #1

wants to merge 2 commits into from

Conversation

Ulminator
Copy link
Owner

  • Will need to add comments documenting the functions. Some testing would also be great, just ran the functions locally for validation.
  • Should we replace all usage of WriteCommand with WriteCommandWithContext? The idea being to eventually rename WriteCommandWithContext to WriteCommand and remove the older version of WriteCommand.

Ulminator
Ulminator commented Apr 16, 2024
View reviewed changes
conn.go
return c.ConnectWithContext(ctx)
}

func (c *Conn) ConnectWithContext(ctx context.Context) (*IdentifyResponse, error) {
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would we want to use ConnectWithContext in consumer.go as well?

@Ulminator
Copy link
Owner Author

Closing to create PR against nsqio

@Ulminator Ulminator closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Ulminator