Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4주차/jerry] 워크북 제출합니다 #60

Merged
merged 5 commits into from
Nov 8, 2024

Conversation

gaaahee
Copy link
Contributor

@gaaahee gaaahee commented Nov 5, 2024

✅ 워크북 체크리스트

  • 모든 핵심 키워드 정리를 마쳤나요?
  • 핵심 키워드에 대해 완벽히 이해하셨나요?
  • 이론 학습 이후 직접 실습을 해보는 시간을 가졌나요?
  • 미션을 수행하셨나요?
  • 미션을 기록하셨나요?

✅ 컨벤션 체크리스트

  • 디렉토리 구조 컨벤션을 잘 지켰나요?
  • pr 제목을 컨벤션에 맞게 작성하였나요?
  • pr에 해당되는 이슈를 연결하였나요?(중요)
  • 적절한 라벨을 설정하였나요?
  • 파트장에게 code review를 요청하기 위해 reviewer를 등록하였나요?
  • 닉네임/main 브랜치의 최신 상태를 반영하고 있는지 확인했나요?(매우 중요!)

📌 주안점

@gaaahee gaaahee requested a review from lsy1307 November 5, 2024 16:11
@gaaahee gaaahee self-assigned this Nov 5, 2024
@gaaahee gaaahee changed the base branch from main to jerry/main November 5, 2024 16:11
@gaaahee gaaahee changed the title [4주차 / jerry] 워크북 제출합니다 [4주차/jerry] 워크북 제출합니다 Nov 5, 2024
@gaaahee
Copy link
Contributor Author

gaaahee commented Nov 5, 2024

영화 버튼 클릭하면 에러가 뜨는데 아마 api 받아올 때 문제가 있는 것 같습니다ㅠㅠ
일단 pr 먼저 올렸고 코드 수정해서 제출하도록 하겠습니다..😭

lsy1307
lsy1307 previously approved these changes Nov 6, 2024
Copy link

@lsy1307 lsy1307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

제리 수고하셨습니다!

@gaaahee gaaahee requested a review from lsy1307 November 8, 2024 06:03
@gaaahee
Copy link
Contributor Author

gaaahee commented Nov 8, 2024

4주차 API 오류 해결했습니다 다시 검토 부탁드립니다!

Copy link

@lsy1307 lsy1307 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생많았어요 제리!

@gaaahee gaaahee merged commit 6007b0d into UMC-Inha:jerry/main Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Chapter04_useNavigate, useParams, useLocation, custom-hook 사용 방법
2 participants