Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalise line endings to LF #574

Merged
merged 2 commits into from
Jan 16, 2025
Merged

Normalise line endings to LF #574

merged 2 commits into from
Jan 16, 2025

Conversation

penelopeysm
Copy link
Member

This PR:

  • runs dos2unix on every text file in the repository to convert any stray CRLFs to LFs,
  • adds a .gitattributes file to keep them the same under future edits.

@penelopeysm penelopeysm requested a review from mhauru January 16, 2025 11:53
Copy link
Member

@mhauru mhauru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful

.gitattributes Show resolved Hide resolved
@mhauru
Copy link
Member

mhauru commented Jan 16, 2025

Do you know what's up with the failing version consistency check, "Unsatisfiable requirements detected"? Seemed to pass a couple of weeks ago.

@penelopeysm
Copy link
Member Author

So what's happening is it's probably trying to upgrade to Turing 0.36, and then it finds it can't, probably because either of the two upstream dependencies (TuringBenchmarking.jl, or Pathfinder.jl) haven't released a version that's compatible with 0.36.

@penelopeysm
Copy link
Member Author

(I suppose that this is the problem in a system that uses conservative upper bounds + frequent minor releases)

Copy link
Contributor

Preview the changes: https://turinglang.org/docs/pr-previews/574
Please avoid using the search feature and navigation bar in PR previews!

@penelopeysm penelopeysm merged commit e6dc047 into master Jan 16, 2025
1 of 2 checks passed
@penelopeysm penelopeysm deleted the py/line-endings branch January 16, 2025 15:33
github-actions bot added a commit that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants