-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mention of GibbsConditional from API docs #2467
Conversation
Could you rebase against master (is it just edd8a4e that needs to be cherry-picked?) |
Yeah, sorry about that, working on it |
edd8a4e
to
a7d8621
Compare
Done. Sorry about that, I thought I could be really quick with this and didn't check the base branch I was working on. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My experience with PRs has always been that requesting a review from someone makes me suddenly realise all the things I messed up 😄
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2467 +/- ##
=======================================
Coverage 85.01% 85.01%
=======================================
Files 21 21
Lines 1582 1582
=======================================
Hits 1345 1345
Misses 237 237 ☔ View full report in Codecov by Sentry. |
Pull Request Test Coverage Report for Build 12786242323Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Some final mop up before making the release.