Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mention of GibbsConditional from API docs #2467

Merged
merged 1 commit into from
Jan 15, 2025

Conversation

mhauru
Copy link
Member

@mhauru mhauru commented Jan 15, 2025

Some final mop up before making the release.

@mhauru mhauru requested a review from penelopeysm January 15, 2025 10:15
@penelopeysm
Copy link
Member

Could you rebase against master (is it just edd8a4e that needs to be cherry-picked?)

@mhauru
Copy link
Member Author

mhauru commented Jan 15, 2025

Yeah, sorry about that, working on it

@mhauru mhauru force-pushed the mhauru/remove-gibbs-conditional-docs branch from edd8a4e to a7d8621 Compare January 15, 2025 10:21
@mhauru
Copy link
Member Author

mhauru commented Jan 15, 2025

Done. Sorry about that, I thought I could be really quick with this and didn't check the base branch I was working on.

Copy link
Member

@penelopeysm penelopeysm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My experience with PRs has always been that requesting a review from someone makes me suddenly realise all the things I messed up 😄

Copy link

codecov bot commented Jan 15, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.01%. Comparing base (11944c9) to head (a7d8621).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2467   +/-   ##
=======================================
  Coverage   85.01%   85.01%           
=======================================
  Files          21       21           
  Lines        1582     1582           
=======================================
  Hits         1345     1345           
  Misses        237      237           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mhauru mhauru merged commit 24d5556 into master Jan 15, 2025
58 of 61 checks passed
@mhauru mhauru deleted the mhauru/remove-gibbs-conditional-docs branch January 15, 2025 10:31
@coveralls
Copy link

Pull Request Test Coverage Report for Build 12786242323

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 76.459%

Totals Coverage Status
Change from base Build 12786060828: 0.0%
Covered Lines: 1205
Relevant Lines: 1576

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants