Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated caf.toolkit version and removed redundant code #42

Merged
merged 2 commits into from
Aug 21, 2024
Merged

updated caf.toolkit version and removed redundant code #42

merged 2 commits into from
Aug 21, 2024

Conversation

Kieran-Fishwick-TfN
Copy link
Contributor

Describe Changes

fixed gravity model calibration results plot_distribution method and updated dependences to newest version of caf.toolkit which is required for the fix
Task Checklist

  • [ NA] Have unittests been added (testing individual functions and their edge cases)
  • [NA ] Have integration tests been added (if applicable, to test modules of functionality)
  • [NA ] Updated RELEASE.md to reflect changes in PR
  • [NA ] Is the documentation building correctly with a clean version number?
  • [YES ] Have new dependencies been added?
    • [YES ] Have they been added to either requirements.txt or requirements_dev.txt.
    • [YES ] Have they been added to setup.cfg

MattBuckley-TfN
MattBuckley-TfN approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@MattBuckley-TfN MattBuckley-TfN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Kieran-Fishwick-TfN Kieran-Fishwick-TfN merged commit 0821db9 into main Aug 21, 2024
15 checks passed
@MattBuckley-TfN MattBuckley-TfN deleted the fix_GM_calibration_plotting branch September 3, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MattBuckley-TfN MattBuckley-TfN MattBuckley-TfN approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Kieran-Fishwick-TfN @MattBuckley-TfN