Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lua-based notifications #211

Draft
wants to merge 40 commits into
base: master
Choose a base branch
from
Draft

Lua-based notifications #211

wants to merge 40 commits into from

Conversation

dssecret
Copy link
Collaborator

@dssecret dssecret commented Dec 5, 2024 •
edited
Loading

  • Trigger creation
  • Trigger updating
  • Notification creation from triggers
  • List official triggers
  • Update notifications in guilds
  • Send audit messages re notifications in audit channel
  • Add selections for all resources
  • Review/update Elixir sandboxing of notifications
  • Add some more pre-defined notifications
  • Create a method for automatically loading official notifications from the git repo
  • Delete a notification from a guild
  • Allow guilds to toggle notifications
  • Create Ecto migrations for this
  • Send messages upon notification trigger
  • Update notification state upon lua completion
  • Handle notification errors

@dssecret
Remove stakeouts from Tornium
723f69d 
Signed-off-by: tiksan <[email protected]>
@dssecret
Delete old stocks config in dashboard
067f6ff 
Signed-off-by: tiksan <[email protected]>
@dssecret
Remove unused tasks.misc.remove_unknown_channel
aaad483 
Signed-off-by: tiksan <[email protected]>
@dssecret
[indev] Add trigger creation frontend
d9771c4 
Signed-off-by: tiksan <[email protected]>
@dssecret
[indev] Add lua code execution for triggers
95a820b 
Signed-off-by: tiksan <[email protected]>
@dssecret
[indev] Add crontab parsing and DB updates
777c7b4 
Signed-off-by: tiksan <[email protected]>
@dssecret
Add trigger schemas
e859045 
Signed-off-by: tiksan <[email protected]>
@dssecret
Fix certain schemas
98af9be 
Signed-off-by: tiksan <[email protected]>
@dssecret
[indev] Add start of Oban workers
e4f5355 
Signed-off-by: tiksan <[email protected]>
@dssecret
[indev] Fix notification table and add Oban worker for notification s…
5a58e48 
…cheduling

Signed-off-by: tiksan <[email protected]>
@dssecret
[indev] Update frontend to handle trigger creation
ff6c1b4 
Signed-off-by: tiksan <[email protected]>
@dssecret
Remove stocks notifications
e4c343f 
Signed-off-by: tiksan <[email protected]>
@dssecret
Black reformat
908f19e 
Signed-off-by: tiksan <[email protected]>
@dssecret
[indev] Add more UI elements for trigger creation and viewing
10c716c 
Signed-off-by: tiksan <[email protected]>
@dssecret
[indev] Add more data to trigger viewer
5740c58 
Signed-off-by: tiksan <[email protected]>
@dssecret
Updated SCSS-based theme/style system
60b0b1d
@dssecret
Remove old themes
91705c7 
Signed-off-by: tiksan <[email protected]>
@dssecret
Add trigger parameters, trigger message type, and trigger message tem…
cdace53 
…plate

Signed-off-by: tiksan <[email protected]>
@dssecret
Update trigger UI to view already-created triggers
747e380 
Signed-off-by: tiksan <[email protected]>
@dssecret
Updated trigger API to allow for updating triggers
964e177 
Signed-off-by: tiksan <[email protected]>
@dssecret
Added basic docs for triggers
c78af7c 
Signed-off-by: tiksan <[email protected]>
@dssecret
Add initial basic example notification
ed4bfbf 
Signed-off-by: tiksan <[email protected]>
@dssecret
[indev] Add start of notification setup
43b8475 
Signed-off-by: tiksan <[email protected]>
@dssecret
[indev] Update notification setup
5247b34 
Signed-off-by: tiksan <[email protected]>
@dssecret
Reformat
5c0998e 
Signed-off-by: tiksan <[email protected]>
@dssecret
[indev] Continue notification setup
8d22dd0 
Signed-off-by: tiksan <[email protected]>
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 5, 2024
View reviewed changes
application/static/components/dynamic-list.js

const header = document.createElement("div");
header.classList.add("card-header");
header.innerHTML = this.getAttribute("data-header");

Check warning

Code scanning / CodeQL

DOM text reinterpreted as HTML Medium

DOM text
Loading
is reinterpreted as HTML without escaping meta-characters.

Copilot Autofix AI about 1 month ago

To fix the problem, we need to ensure that the content of the data-header attribute is treated as plain text rather than HTML. This can be achieved by using the textContent property instead of innerHTML. The textContent property will escape any HTML tags, preventing the execution of any embedded scripts.

  • Change the assignment of header.innerHTML to header.textContent on line 37.
  • No additional imports or definitions are needed for this change.
Suggested changeset 1
application/static/components/dynamic-list.js

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/application/static/components/dynamic-list.js b/application/static/components/dynamic-list.js
--- a/application/static/components/dynamic-list.js
+++ b/application/static/components/dynamic-list.js
@@ -36,3 +36,3 @@
         header.classList.add("card-header");
-        header.innerHTML = this.getAttribute("data-header");
+        header.textContent = this.getAttribute("data-header");
         card.append(header);
EOF
@@ -36,3 +36,3 @@
header.classList.add("card-header");
header.innerHTML = this.getAttribute("data-header");
header.textContent = this.getAttribute("data-header");
card.append(header);
Copilot is powered by AI and may make mistakes. Always verify output.
Positive Feedback
Negative Feedback

Provide additional feedback

Please help us improve GitHub Copilot by sharing more details about this comment.

Please select one or more of the options
dssecret added 12 commits December 6, 2024 18:10
@dssecret
[indev] Update luerl processing of notifications
05cebf6 
Signed-off-by: tiksan <[email protected]>
@dssecret
[indev] Add template rendering for notifications
db7c0df 
Signed-off-by: tiksan <[email protected]>
@dssecret
Reformat
29ec549 
Signed-off-by: tiksan <[email protected]>
@dssecret
[indev] Send messages upon notification trigger
c32f51b 
Signed-off-by: tiksan <[email protected]>
@dssecret
[indev] Add audit messages
24b8299 
Signed-off-by: tiksan <[email protected]>
@dssecret
Reformat
5c52806 
Signed-off-by: tiksan <[email protected]>
@dssecret
[indev]
7c8a3d1 
Signed-off-by: tiksan <[email protected]>
@dssecret
Reformat
395c578 
Signed-off-by: tiksan <[email protected]>
@dssecret
Misc bug fixes
518777d 
Signed-off-by: tiksan <[email protected]>
@dssecret
Fix notification bot API endpoints
8691481 
Signed-off-by: tiksan <[email protected]>
@dssecret
Update solid version
cb7ee14 
Signed-off-by: tiksan <[email protected]>
@dssecret
[indev] Add toggling of notifications in a guild
bcf74d5 
Signed-off-by: tiksan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dssecret