odb: protecting LefParser and DefParser namespaces #6475
Conversation
Signed-off-by: Lucas Yuki Imamura <[email protected]>
Signed-off-by: Lucas Yuki Imamura <[email protected]>
Signed-off-by: Lucas Yuki Imamura <[email protected]>
Signed-off-by: Lucas Yuki Imamura <[email protected]>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| { | ||
| odb::dbTechLayerCutSpacingTableOrthRule* rule | ||
| = odb::dbTechLayerCutSpacingTableOrthRule::create(parser->layer); | ||
| std::vector<std::pair<int, int>> table; | ||
| for (const auto& item : params) | ||
| table.push_back( | ||
| {lefin->dbdist(at_c<0>(item)), lefin->dbdist(at_c<1>(item))}); | ||
| table.push_back({lefinReader->dbdist(at_c<0>(item)), |
There was a problem hiding this comment.
warning: 'push_back' is called inside a loop; consider pre-allocating the container capacity before the loop [performance-inefficient-vector-operation]
src/odb/src/lefin/lefTechLayerCutSpacingTableParser.cpp:46:
- for (const auto& item : params)
+ table.reserve(params.size());
+ for (const auto& item : params)| table.push_back({lefinReader->dbdist(at_c<0>(item)), | ||
| lefinReader->dbdist(at_c<1>(item))}); |
There was a problem hiding this comment.
warning: use emplace_back instead of push_back [modernize-use-emplace]
| table.push_back({lefinReader->dbdist(at_c<0>(item)), | |
| lefinReader->dbdist(at_c<1>(item))}); | |
| table.emplace_back(lefinReader->dbdist(at_c<0>(item)), | |
| lefinReader->dbdist(at_c<1>(item))); |
| @@ -110,11 +111,11 @@ void lefin::init() | |||
| } | |||
| } | |||
|
|
|||
| lefin::~lefin() | |||
| lefinReader::~lefinReader() | |||
There was a problem hiding this comment.
warning: use '= default' to define a trivial destructor [modernize-use-equals-default]
src/odb/src/lefin/lefin.cpp:114:
- {
- }
+ = default;
| std::mutex defin::_def_mutex; | ||
|
|
||
| defin::defin(dbDatabase* db, utl::Logger* logger, MODE mode) | ||
| { | ||
| std::lock_guard<std::mutex> lock(_def_mutex); | ||
| _reader = new definReader(db, logger, mode); | ||
| } | ||
|
|
||
| defin::~defin() | ||
| { | ||
| std::lock_guard<std::mutex> lock(_def_mutex); |
There was a problem hiding this comment.
I'm not clear the locking is doing anything here. It kind of looks like this is trying to protect two defin's from running at the same time on the same database, but what we're really concerned about is two different defin's running on two different databases.
What are these locks here to do?
Protects the global and static variables in the LefParser and DefParser namespaces (issue #5981)
Changes: