Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ppl: support multiple track patterns #6466

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

ppl: support multiple track patterns #6466

wants to merge 5 commits into from

Conversation

eder-matheus
Copy link
Collaborator

Fix #3119

@eder-matheus eder-matheus requested a review from maliberty January 3, 2025 17:14
github-actions[bot]
github-actions bot reviewed Jan 3, 2025
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

src/ppl/src/IOPlacer.cpp Outdated Show resolved Hide resolved
@eder-matheus
ppl: clang-tidy
51ade20 
Signed-off-by: Eder Monteiro <[email protected]>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 3, 2025

clang-tidy review says "All clean, LGTM! 👍"

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

clang-tidy review says "All clean, LGTM! 👍"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@maliberty maliberty Awaiting requested review from maliberty

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

support multiple track patterns in ppl
1 participant
@eder-matheus