-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ Feat : 브리핑 수정 API 구현 #144
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,10 @@ | ||
package briefing.briefing.application; | ||
|
||
import java.util.List; | ||
import java.util.Optional; | ||
|
||
import briefing.exception.ErrorCode; | ||
import briefing.exception.handler.BriefingException; | ||
import org.springframework.stereotype.Service; | ||
import org.springframework.transaction.annotation.Transactional; | ||
|
||
|
@@ -15,6 +18,8 @@ | |
import briefing.briefing.domain.repository.BriefingRepository; | ||
import lombok.RequiredArgsConstructor; | ||
|
||
import javax.swing.text.html.Option; | ||
|
||
@Service | ||
@Transactional | ||
@RequiredArgsConstructor | ||
|
@@ -36,4 +41,18 @@ public void createBriefing(final BriefingRequestDTO.BriefingCreate request) { | |
articles.stream().map(article -> new BriefingArticle(briefing, article)).toList(); | ||
briefingArticleRepository.saveAll(briefingArticles); | ||
} | ||
|
||
public Briefing updateBriefing(Long id, final BriefingRequestDTO.BriefingUpdateDTO request){ | ||
|
||
// throw 부분을 컨트롤러에서 validator annotation을 사용하는 것이 더 좋을지?? | ||
Briefing briefing = briefingRepository.findById(id).orElseThrow(() -> new BriefingException(ErrorCode.NOT_FOUND_BRIEFING)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 우선은 서비스 계층에서 이런 형태로 방어적으로 작성해도 무방하다고 생각합니다. |
||
|
||
|
||
// 이 코드 더 깔끔하게 리팩토링이 가능할지?? | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 코드가 의도를 조금 더 명확히 담으면 좋을 것 같습니다. 아래는 예시입니다. |
||
Optional.ofNullable(request.getContent()).ifPresent(briefing::setContent); | ||
Optional.ofNullable(request.getTitle()).ifPresent(briefing::setTitle); | ||
Optional.ofNullable(request.getSubTitle()).ifPresent(briefing::setSubtitle); | ||
|
||
return briefing; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
동의합니다!
관리자 권한 유저에게만 열어줘야 할 것 같습니다.