Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor - request dto에서 validation을 진행할 수 있도록 변경 #165

Merged
merged 21 commits into from
Jun 18, 2024

Conversation

kseysh
Copy link
Member

@kseysh kseysh commented Jun 12, 2024

Related issue 🚀

Work Description 💚

  • request dto에서 validation을 적용하여 request를 이용해 validation을 빼먹는 일이 없도록 하였고, 가독성을 향상시켰습니다.

PR 참고 사항

  • 한 가지 단점으로는 Error Constants를 사용하지 못하는게 단점인 것 같네요!

@kseysh kseysh added 👨🏻‍💻 승환 승환이가 작성한 Label 🔨 Refactor 코드 리펙토링 (기능 변경 없이 코드만 수정할 때) labels Jun 12, 2024
@kseysh kseysh requested a review from jumining June 12, 2024 08:22
@kseysh kseysh self-assigned this Jun 12, 2024
Copy link
Collaborator

@jumining jumining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

승인했습니다:)

public static final Integer USAGE_POINT = 100;
public static final Integer EARNED_POINT = 20;

public static final List<Integer> AVAILABLE_CHALLENGE_PERIODS = List.of(7, 14, 20, 30);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@kseysh kseysh requested a review from jumining June 18, 2024 07:12
Copy link
Collaborator

@jumining jumining left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

커밋 단위 잘 쪼개셨군요 작업 감사합니다 수고하셨어요😀

@kseysh kseysh merged commit 2622309 into develop Jun 18, 2024
1 check passed
@jumining jumining changed the title refactor: request dto에서 validation을 진행할 수 있도록 변경 refactor - request dto에서 validation을 진행할 수 있도록 변경 Nov 19, 2024
@jumining jumining deleted the refactor/#164-validation-use-annotation branch November 19, 2024 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
👨🏻‍💻 승환 승환이가 작성한 Label 🔨 Refactor 코드 리펙토링 (기능 변경 없이 코드만 수정할 때)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactor - @Valid를 이용해 validation하도록 변경
2 participants