refactor - #122 가독성을 위한 네이밍 변경

Team-HMH · Jun 18, 2024 · d712315 · d712315
1 parent d4eb82a
commit d712315
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 5 deletions.
diff --git a/src/main/java/sopt/org/hmh/domain/auth/service/AuthFacade.java b/src/main/java/sopt/org/hmh/domain/auth/service/AuthFacade.java
@@ -26,7 +26,6 @@ public class AuthFacade {
 
     private final KakaoLoginService kakaoLoginService;
     private final AppleOAuthProvider appleOAuthProvider;
-
     private final ChallengeFacade challengeFacade;
     private final ChallengeAppService challengeAppService;
     private final TokenService tokenService;

diff --git a/src/main/java/sopt/org/hmh/domain/challenge/controller/ChallengeController.java b/src/main/java/sopt/org/hmh/domain/challenge/controller/ChallengeController.java
@@ -60,7 +60,7 @@ public ResponseEntity<BaseResponse<DailyChallengeResponse>> orderGetDailyChallen
     public ResponseEntity<BaseResponse<?>> orderAddApps(@UserId final Long userId,
                                                         @RequestHeader("OS") final String os,
                                                         @RequestBody @Valid final ChallengeAppArrayRequest requests) {
-        challengeFacade.addApps(userId, requests.apps(), os);
+        challengeFacade.addAppsToCurrentChallenge(userId, requests.apps(), os);
 
         return ResponseEntity
                 .status(AppSuccess.ADD_APP_SUCCESS.getHttpStatus())
@@ -73,7 +73,7 @@ public ResponseEntity<BaseResponse<?>> orderAddApps(@UserId final Long userId,
     public ResponseEntity<BaseResponse<?>> orderRemoveApp(@UserId final Long userId,
                                                           @RequestHeader("OS") final String os,
                                                           @RequestBody @Valid final AppRemoveRequest request) {
-        challengeFacade.removeApp(userId, request.appCode(), os);
+        challengeFacade.removeAppFromCurrentChallenge(userId, request.appCode(), os);
 
         return ResponseEntity
                 .status(AppSuccess.REMOVE_APP_SUCCESS.getHttpStatus())

diff --git a/src/main/java/sopt/org/hmh/domain/challenge/service/ChallengeFacade.java b/src/main/java/sopt/org/hmh/domain/challenge/service/ChallengeFacade.java
@@ -95,13 +95,13 @@ private Integer calculateTodayIndex(LocalDateTime challengeCreateAt, int period)
     }
 
     @Transactional
-    public void addApps(Long userId, List<ChallengeAppRequest> requests, String os) {
+    public void addAppsToCurrentChallenge(Long userId, List<ChallengeAppRequest> requests, String os) {
         Challenge challenge = this.findCurrentChallengeByUserId(userId);
         challengeAppService.addApps(challenge, requests, os);
     }
 
     @Transactional
-    public void removeApp(Long userId, String appCode, String os) {
+    public void removeAppFromCurrentChallenge(Long userId, String appCode, String os) {
         Challenge challenge = this.findCurrentChallengeByUserId(userId);
         challengeAppService.removeApp(challenge, appCode, os);
     }