위치 권한 허용 안함 시 설정으로 이동 토스트 노출 #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hanchang97
approved these changes
May 22, 2024
| @@ -331,6 +333,7 @@ private fun MapContent( | |||
| it.start( | |||
| object : MapLifeCycleCallback() { | |||
| override fun onMapDestroy() { | |||
| map = null | |||
There was a problem hiding this comment.
null 값을 명시적으로 할당해주신 이유가 궁금합니다!
There was a problem hiding this comment.
@hanchang97
에러가 났었습니다. 정확히 기억이 안나는데 map 인스턴스가 2개가 있으면 안되는것 같았어요
근데 다른 화면 이동하고 다시 돌아오면 리컴포지션 발생 중에 타이밍 이슈로 인해서 인스턴스가 2개 있었던 것 같아요
그래서 map을 명시적으로 Destroy 될때 null처리를 했습니다.
There was a problem hiding this comment.
@hanchang97 일단 머지하고 주석으로 이유 작성할게요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구체적인 작업 내용
Close Issue
Close #71