지도 위치 권한 유도 팝업 및 이동 로직 수정 #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ows3090
commented
May 4, 2024
| ), | ||
| containerColor = BuddyConTheme.colors.modalColor, | ||
| dragHandle = { | ||
| BottomSheetDialog(onDismissRequest = onDismiss) { |
There was a problem hiding this comment.
@hanchang97
ModalBottomSheet가 높이가 절반 이상은 지정 안되는 이슈로 서드파티 라이브러리 사용했습니다
There was a problem hiding this comment.
그런 이슈가 있군요.. 배포 후에 라이브러리 없이 혹시 구현할 수 있는지 같이 스터디 해보면 좋을 것 같습니다😀
| @@ -18,6 +19,7 @@ interface GiftiConService { | |||
| suspend fun requestAvailableGiftiCons( | |||
| @Query("pageNumber") pageNumber: Int, // page | |||
| @Query("gifticonStoreCategory") gifticonStoreCategory: String?, // 기프티콘 가게 카테고리 | |||
| @Query("gifticonStore") gifticonStore: String? = null, | |||
There was a problem hiding this comment.
@hanchang97
API 문서상 gifticonStore가 있어서 추가했습니다
| GS25("GS25", "GS25"), | ||
| CU("CU", "CU"), | ||
| OTHERS("기타", "OTHERS'"), | ||
| NONE("", "") |
There was a problem hiding this comment.
@hanchang97
기타가 OTHERS 파라미터로 넣어야만 가능해서 ETC에서 변경했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구체적인 작업 내용
지도 위치 권한 유도 팝업 및 이동 로직 수정
Close Issue
Close #60