feat: 일반 관리자 기능 구현 #14
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Group 엔티티 명을 Role 로 변경 - ManyToOne Fetch Type 을 Lazy로 설정 - Member 엔티티 오타 수정
|
main 브랜치 변경이 있어 |
eunbc
approved these changes
Dec 24, 2023
| @DeleteMapping("/me") | ||
| public ResponseEntity<ApiResponse<Void>> deleteMyAccount() { | ||
| adminService.deleteAdmin(TEMP_CURRENT_ID); | ||
| return ResponseEntity.ok(ApiResponse.ok(null)); |
There was a problem hiding this comment.
Response.noContent 로 리턴해도 될 것 같습니다!
| private final MemberRepository memberRepository; | ||
|
|
||
| @Transactional(readOnly = true) | ||
| public Object getMembers(List<Long> memberIds) { |
There was a problem hiding this comment.
리턴 타입을 명확히 해주면 좋을 것 같아요!
List<MemberSummaryGetResponse>
| private final AdminService adminService; | ||
|
|
||
| @GetMapping("/members") | ||
| public ResponseEntity<ApiResponse<?>> getMembers(@RequestParam(required = false) List<Long> memberIds) { |
There was a problem hiding this comment.
기존 구현이 파라미터의 존재유무에 따라 다른 값을 반환하도록 구현되어 있어
/members와 /members/details 로 엔드포인트 분리하였습니다!
| String phoneNumber, | ||
| String email | ||
| ) { | ||
| public static MemberSummaryGetResponse toDto(Member member) { |
There was a problem hiding this comment.
정적 팩토리 메서드 네이밍 컨벤션 참고해주세요! 참고
from 으로 통일해주는건 어떨까요~?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
구현 기능
추가 변경 사항
dto나 repository를 같이 사용해야 할 것 같아서 최소한의 구현만 하고 PR 올립니다.
Custom Exception 및 Controller Advice는 아직 구현하지 않았고, GlobalControllerAdvice에 대한 논의가 필요할 것 같습니다.
resolve: #10