-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Miscellaneous improvements #177
Open
ostrya
wants to merge
9
commits into
main
Choose a base branch
from
miscellaneous-improvements
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kai Helbig <[email protected]>
If the redirect_uri as given by the client already contained (escaped) query parameters or fragments, we previously ignored them and still appended a new query or fragment part. With this fix, we now append our return values to the existing parts, if necessary. Signed-off-by: Kai Helbig <[email protected]>
ostrya
force-pushed
the
miscellaneous-improvements
branch
from
January 20, 2025 06:58
27e81a2
to
3b3f2cc
Compare
Signed-off-by: Kai Helbig <[email protected]>
Instead of defining a list of resources to apply the roles to, the user can now define a list of default audiences to add. In a new, separate setting, the user can decide whether the roles given by the login shall be applied to the realm, all audiences (which double as resources), or both. This is a breaking API and behavior change! Signed-off-by: Kai Helbig <[email protected]>
Yes, I know that Keycloak proper has stopped serving the keycloak.js file. But since I want to stay somewhat backward-compatible regarding old Keycloak versions, I should still ensure correctness. Signed-off-by: Kai Helbig <[email protected]>
They have been deprecated for almost 4 years now. Let's drop them. Signed-off-by: Kai Helbig <[email protected]>
and UI improvements for login page Signed-off-by: Kai Helbig <[email protected]>
if you are still relying on the shipped js, you probably also want the old version, as v26 introduced some breaking changes Signed-off-by: Kai Helbig <[email protected]>
ostrya
force-pushed
the
miscellaneous-improvements
branch
from
January 20, 2025 07:38
3b3f2cc
to
05fda28
Compare
as there's no useful way of testing this Signed-off-by: Kai Helbig <[email protected]>
ostrya
force-pushed
the
miscellaneous-improvements
branch
from
January 20, 2025 07:46
05fda28
to
9ac87bb
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.