Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Miscellaneous improvements #177

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Miscellaneous improvements #177

wants to merge 9 commits into from

Conversation

ostrya
Copy link
Collaborator

@ostrya ostrya commented Jan 20, 2025

No description provided.

If the redirect_uri as given by the client already contained (escaped) query
parameters or fragments, we previously ignored them and still appended a new
query or fragment part. With this fix, we now append our return values to the
existing parts, if necessary.

Signed-off-by: Kai Helbig <[email protected]>
@ostrya ostrya self-assigned this Jan 20, 2025
@ostrya ostrya force-pushed the miscellaneous-improvements branch from 27e81a2 to 3b3f2cc Compare January 20, 2025 06:58
Signed-off-by: Kai Helbig <[email protected]>
Instead of defining a list of resources to apply the roles to, the user can now
define a list of default audiences to add. In a new, separate setting, the user
can decide whether the roles given by the login shall be applied to the realm,
all audiences (which double as resources), or both.

This is a breaking API and behavior change!

Signed-off-by: Kai Helbig <[email protected]>
Yes, I know that Keycloak proper has stopped serving the keycloak.js file. But
since I want to stay somewhat backward-compatible regarding old Keycloak
versions, I should still ensure correctness.

Signed-off-by: Kai Helbig <[email protected]>
They have been deprecated for almost 4 years now. Let's drop them.

Signed-off-by: Kai Helbig <[email protected]>
and UI improvements for login page

Signed-off-by: Kai Helbig <[email protected]>
if you are still relying on the shipped js, you probably also want the old
version, as v26 introduced some breaking changes

Signed-off-by: Kai Helbig <[email protected]>
@ostrya ostrya force-pushed the miscellaneous-improvements branch from 3b3f2cc to 05fda28 Compare January 20, 2025 07:38
as there's no useful way of testing this

Signed-off-by: Kai Helbig <[email protected]>
@ostrya ostrya force-pushed the miscellaneous-improvements branch from 05fda28 to 9ac87bb Compare January 20, 2025 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant