Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Atualiza framework e dependências #162

Open
wants to merge 14 commits into
base: develop
Choose a base branch
from

Conversation

geidsonc
Copy link
Member

@geidsonc geidsonc commented Nov 18, 2023

Atualizações
  • Laravel 10.x
  • Nova imagem docker
  • Suporte ao uso do laravel/sail
  • Node 18.x
  • Atualiza bibliotecas no package.json
  • Atualiza pacotes do laravel e dependências
Para testar
  • Execute
docker run --rm \
    -u "$(id -u):$(id -g)" \
    -v "$(pwd):/var/www/html" \
    -w /var/www/html \
    laravelsail/php83-composer:latest \
    composer install --ignore-platform-reqs
  • Execute sail up -d --remove-orphans
  • Execute sail npm install
  • Execute sail npm run dev

tassiocaique and others added 4 commits September 27, 2023 13:20
Atualiza master com develop
Atualiza master com develop
Atualiza develop com master
…o laravel/sail. Atualiza imagem docker com suporte ao desenvolvimento. Atualiza versão do nodejs para 18 e dependências do package.json
@geidsonc geidsonc requested a review from uesley November 19, 2023 00:45
@uesley
Copy link
Contributor

uesley commented Mar 17, 2024

já que tem um cliente de email padrão, seria interessante atualizar as variáveis do .env.example para já deixar configurado?
me refiro às variáveis:

MAIL_DRIVER=smtp
- MAIL_HOST=smtp.mailtrap.io
- MAIL_PORT=2525
+ MAIL_HOST=mailpit
+ MAIL_PORT=1025
MAIL_USERNAME=null
MAIL_PASSWORD=null
MAIL_ENCRYPTION=null

@uesley
Copy link
Contributor

uesley commented Mar 17, 2024

e tem uns testes falhando

There were 2 errors:

1) Tests\Feature\App\Http\Controllers\CardControllerTest::testAuthenticatedClientCanCreateCard
TypeError: Laravel\Passport\Guards\TokenGuard::setClient(): Argument #1 ($client) must be of type Laravel\Passport\Client, Sysvale\Mongodb\Passport\Client given, called in /var/www/html/vendor/laravel/passport/src/Passport.php on line 409

/var/www/html/vendor/laravel/passport/src/Guards/TokenGuard.php:368
/var/www/html/vendor/laravel/passport/src/Passport.php:409
/var/www/html/tests/Feature/App/Http/Controllers/CardControllerTest.php:55
/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Testing/TestCase.php:174

2) Tests\Feature\App\Observers\CardObserverTest::testLinkCompanyAndNullUserWhenCreatingCardUsingClient
TypeError: Laravel\Passport\Guards\TokenGuard::setClient(): Argument #1 ($client) must be of type Laravel\Passport\Client, Sysvale\Mongodb\Passport\Client given, called in /var/www/html/vendor/laravel/passport/src/Passport.php on line 409

/var/www/html/vendor/laravel/passport/src/Guards/TokenGuard.php:368
/var/www/html/vendor/laravel/passport/src/Passport.php:409
/var/www/html/tests/Feature/App/Observers/CardObserverTest.php:41
/var/www/html/vendor/laravel/framework/src/Illuminate/Foundation/Testing/TestCase.php:174

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants