feat(gossip): support ContactInfo as equivalent to LegacyContactInfo #68
+181
−41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ContactInfo was being stored in the CrdsTable but it was missing some special treatment that LegacyContactInfo gets: - insertion of CrdsValue is normally filtered by shred version, but LegacyContactInfo is inserted regardless of shred version - getAllContactInfos and getContactInfos are used for tasks like identifying which gossip peers to communicate with. these methods were only returning LegacyContactInfo this change makes it so ContactInfo now gets the same treatment: - unconditional insertion into CrdsTable - returned from contact info methods using new EitherContactInfo tagged union
|
decided not to go this route with EitherContactInfo because it complicates things unnecessarily |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #65
ContactInfo was being stored in the CrdsTable but it was missing some special treatment that LegacyContactInfo gets:
this change makes it so ContactInfo now gets the same treatment: