feat(ci): ensure building passes on macos #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rexicon226
force-pushed
the
Rexicon226/macos-ci
branch
4 times, most recently
from
4dd68f1 to
f2d5314
Compare
Rexicon226
force-pushed
the
Rexicon226/macos-ci
branch
from
ed113b6 to
2657991
Compare
Rexicon226
commented
Jan 14, 2025
Rexicon226
changed the title
0xNineteen
requested changes
Jan 16, 2025
0xNineteen
approved these changes
Jan 16, 2025
dnut
pushed a commit
that referenced
this pull request
Jan 22, 2025
Signed-off-by: Drew Nutter <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm hoping to one day setup CI runners to run the test suite on macos as well, however, Github's CI runners seem to be trolling me a bit and keep swapping the runners between aarch64 and x86-64. This wouldn't be a problem if the aarch64 runner's hwinfo weren't seemingly screwed up and proving incorrect CPU feature detection.
For now, the best solution we can manage is just ensuring that the build succeeds when targeting aarch64-macos from x86_64-linux. Maybe we can setup self-hosted runners at one point?