-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
initial prometheus metrics #37
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s already one in main
implement histogram and gauge. make existing counter conform to standard. rename old "gauge" to "gauge_fn" since it is not a true prometheus gauge but an equivalent of the golang GaugeFunc
dnut
added
enhancement
New feature or request
and removed
enhancement
New feature or request
labels
Dec 18, 2023
metrics structs can use normal initialization so they aren's so esoteric. the registry is the context where we'd like to allocate everything in an arena and manage the memory centrally. so, for clarity, that scope can also be in charge of allocating the structs. that way, the structs can behave as normal structs on their own, without requiring special memory management
…am buckets ownership
dnut
changed the title
initial prometheus metrics and thread pool fork
initial prometheus metrics
Dec 18, 2023
- initialize prometheus registry and http adapter with sig main() - add global registry singleton. - implement OnceCell to safely support global singletons that need to be initialized at runtime - make Counter a normal looking struct (not a file struct) - switch unnecessary .Release operation in histogram to .Monotonic - switch from std.http to httpz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements #60
Forked zig-prometheus, using the following types with misc improvements:
Implemented from scratch: