improvement(accountsdb): add mapping in DiskMemoryAllocator that maps a file's mmap-ed memory address to its filename #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InKryption
reviewed
Jul 3, 2024
aang114
changed the title
InKryption
reviewed
Jul 5, 2024
| @@ -925,11 +925,15 @@ pub const DiskMemoryAllocator = struct { | |||
| count: usize = 0, | |||
| mux: std.Thread.Mutex = .{}, | |||
|
|
|||
| /// HashMap that maps the Mmap-ed memory address of a file to the file's index number | |||
| hashmap: std.AutoHashMap([*]u8, usize), | |||
There was a problem hiding this comment.
I'm not a huge fan of the fact that this introduces a dependency on another allocator which has to potentially also be thread safe. I would like to instead see an approach where the metadata is placed in (disk) memory before or after the user-facing buffer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, a HashMap field has been added to the
DiskMemoryAllocatorthat maps the mmap-ed memory address of a file to its filename so that the file can be deleted from storage whenDiskMemoryAllocator::free()is called.Note: This PR attempts to resolve part of the issue mentioned in https://github.com/orgs/Syndica/projects/2?pane=issue&itemId=56221388: