fix(accountsdb): status cache integer overflow when slot = 0 #175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
reproduce:
stack trace:
cause:
When
slot_history.oldest()
is zero,slot -= 0
triggers this error on the last iteration. The test snapshot included in the repo includes slot zero. By default the code runs using that snapshot, which is why this error happens with the simple command above.fix:
At the end of the iteration, and before the decrement, break if the slot is zero.