Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improvement(build.zig): More consistent name & don't depend on install to reduce redundant compilation times #172

Merged
merged 1 commit into from
Jun 11, 2024
Merged

improvement(build.zig): More consistent name & don't depend on install to reduce redundant compilation times #172

merged 1 commit into from
Jun 11, 2024

Conversation

InKryption
Copy link
Contributor

  • unit_tests -> unit_tests_exe reflects the naming convention of all the other artifacts, alongside unit_tests_run -> unit_tests_exe_run.
  • Don't make all run steps depend on the global install step, because doing so makes running any single artifact recompile every single artifact, which is a waste of time during iteration.

@InKryption
More consistent name & don't depend on install
0972bec 
* unit_tests -> unit_tests_exe reflects the naming convention of all
  the other artifacts, alongside unit_tests_run -> unit_tests_exe_run.
* Don't make all run steps depend on the global install step, because
  doing so makes running any single artifact recompile every single
  artifact, which is a waste of time during iteration.
@InKryption InKryption self-assigned this Jun 11, 2024
@InKryption InKryption requested a review from dnut June 11, 2024 16:24
@0xNineteen 0xNineteen merged commit 0298d20 into main Jun 11, 2024
5 checks passed
@0xNineteen 0xNineteen deleted the ink/better-build2 branch June 11, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xNineteen 0xNineteen 0xNineteen approved these changes

@dnut dnut Awaiting requested review from dnut

Assignees

@InKryption InKryption

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@InKryption @0xNineteen