-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redis Support for FedScale #170
Draft
xuyehe
wants to merge
13
commits into
SymbioticLab:master
Choose a base branch
from
xuyehe:redis
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
a443f24
changed environment.yml
64fdecc
added install script for redis, added shell/python script to start re…
b7c1427
added util functions for redis
0791e3d
init support of redis in aggregator, but driver cannot start aggregat…
368a515
fixed test_result_accumulator not serialized, changed conda env name
454761e
added model saving in aggregator.py
fec5530
code cleaning
13575dd
Added redis conf to femnist's conf.yml and arg parse; modified server…
aa9c4c8
Commit conf
e9a22ea
Added tag to keys to distinguish between jobs storing into same redis…
baf44a3
Changed print to logging
812c1a4
merge main
d0dc363
Modify install.sh to make redis install optional
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -33,4 +33,6 @@ stackoverflow | |
common_voice | ||
puffer | ||
landmark | ||
coqa | ||
coqa | ||
dump.rdb | ||
*.pid |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -6,6 +6,7 @@ dependencies: | |
- tensorboard | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I remember you mentioned that some tf version is not compatible. Can you please update tf version here too? |
||
- numba=0.49.1 | ||
- pip=20.0.2 | ||
- redis-py=3.5.3 | ||
- pip: | ||
- torch_optimizer | ||
- torch | ||
|
Large diffs are not rendered by default.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we remove the hardcoded path? Instead, use some like os.environ["REDIS_PATH"]