Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: release v2.9.1 #3688

Merged
merged 20 commits into from
Jan 18, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
7072080
chore(service): return cli version in core svc (#3655)
Panaetius Dec 20, 2023
ec1e282
fix(cli): use lower case image names for sessions in upper-case proje…
Panaetius Dec 20, 2023
8afaedd
fix(service): add proper error if a dataset can't be found (#3661)
Panaetius Dec 21, 2023
5954aac
fix: prevent distutils warning (#3663)
Panaetius Jan 3, 2024
d74cc72
fix(service): allow editing datasets without creator email (#3664)
Panaetius Jan 3, 2024
12469f9
fix(cli): output proper session link and only check registry if logge…
Panaetius Jan 4, 2024
9377ac4
fix(service): allow setting keywords on project creation (#3665)
Panaetius Jan 4, 2024
77f480f
chore: combined dependency update (#3672)
github-actions[bot] Jan 11, 2024
a7f4a22
feat(service): date_published in datasets.list response (#3648)
m-alisafaee Jan 12, 2024
0c523fa
fix(service): fix clone depth not being respected (#3678)
Panaetius Jan 15, 2024
e7cdd7a
Merge branch 'master' into develop
Jan 16, 2024
3f074ce
Merge branch 'master' into develop
Jan 16, 2024
7d5dd08
Merge branch 'master' into develop
Jan 16, 2024
7a4c9a9
Merge branch 'master' into develop
Jan 16, 2024
00da768
fix(service): accept commit-sha in config.show (#3685)
m-alisafaee Jan 17, 2024
ec3173a
feat: add cloud storage support for session start (#3629)
Panaetius Jan 17, 2024
a98a23c
Merge branch 'master' into develop
Panaetius Jan 18, 2024
398ec2e
fix(svc): fix migration not working with old template metadata (#3687)
Panaetius Jan 18, 2024
8608c40
chore: release v2.9.1
RenkuBot Jan 18, 2024
fafec5a
update changelog
Panaetius Jan 18, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions CHANGES.rst
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,17 @@
Changes
=======

`2.9.1 <https://github.com/SwissDataScienceCenter/renku-python/compare/v2.9.0...v2.9.1>`__ (2024-01-18)
-------------------------------------------------------------------------------------------------------

Bug Fixes
~~~~~~~~~

- **svc:** fix migration not working with old template metadata
(`#3687 <https://github.com/SwissDataScienceCenter/renku-python/issues/3687>`__)
(`398ec2e <https://github.com/SwissDataScienceCenter/renku-python/commit/398ec2ef35ec296aa55f3cdd568e35eaa360cd89>`__)


`2.9.0 <https://github.com/SwissDataScienceCenter/renku-python/compare/v2.8.2...v2.9.0>`__ (2024-01-17)
-------------------------------------------------------------------------------------------------------

Expand Down
2 changes: 1 addition & 1 deletion helm-chart/renku-core/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@ appVersion: "1.0"
description: A Helm chart for Kubernetes
name: renku-core
icon: https://avatars0.githubusercontent.com/u/53332360?s=400&u=a4311d22842343604ef61a8c8a1e5793209a67e9&v=4
version: 2.9.0
version: 2.9.1
2 changes: 1 addition & 1 deletion helm-chart/renku-core/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,4 +8,4 @@ global:
versions:
latest:
image:
tag: v2.9.0
tag: v2.9.1
7 changes: 6 additions & 1 deletion renku/core/migration/migrate.py
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,12 @@ def migrate_project(
except Exception as e:
raise TemplateUpdateError("Couldn't update from template.") from e

if not skip_docker_update:
if (
not skip_docker_update
and project
and hasattr(project, "template_metadata")
and isinstance(project.template_metadata, ProjectTemplateMetadata)
):
try:
docker_updated, _, _ = update_dockerfile()
except DockerfileUpdateError:
Expand Down
16 changes: 15 additions & 1 deletion renku/ui/service/controllers/cache_migrate_project.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,27 @@ def execute_migration(
project_path, force_template_update, skip_template_update, skip_docker_update, skip_migrations, commit_message
):
"""Execute project migrations."""
from renku.command.migrate import migrate_project_command
from renku.command.migrate import (
AUTOMATED_TEMPLATE_UPDATE_SUPPORTED,
DOCKERFILE_UPDATE_POSSIBLE,
TEMPLATE_UPDATE_POSSIBLE,
check_project,
migrate_project_command,
)

worker_log.debug(f"migrating {project_path}")

communicator = ServiceCallback()

with renku_project_context(project_path):
status = check_project().build().execute().output

template_update_possible = status & TEMPLATE_UPDATE_POSSIBLE and status & AUTOMATED_TEMPLATE_UPDATE_SUPPORTED
docker_update_possible = status & DOCKERFILE_UPDATE_POSSIBLE

skip_docker_update = skip_docker_update or not docker_update_possible
skip_template_update = skip_template_update or not template_update_possible

result = (
migrate_project_command()
.with_commit(message=commit_message)
Expand Down