SSW-302: Redundant stake address check #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TxPipe pointed out that we had a redundant check for the stake address, but this revealed a more subtle issue. Previously, we were checking that the address didn't change between the pool output and the pool input. Then, we also checked that the staking key didn't change. However, this would have locked a pool with the same staking key forever. The intention is to allow the treasury administrator to change the staking address if needed. This resolves it by moving the full address check into the Scoop redeemer path. In the Withdraw path, we require that the payment key stay fixed, but allow the staking key to be set to any allowed_staking_key from the settings datum. Note that this required us to change the `authorized_staking_keys` to a list of Credentials, so we could easily compare, though this is expected to have low impact.
|
lgtm |
Quantumplation
changed the title
|
LGTM. We didn't review the WithdrawFees redeemer yet but it looks good for the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TxPipe pointed out that we had a redundant check for the stake address, but this revealed a more subtle issue.
Previously, we were checking that the address didn't change between the pool output and the pool input. Then, we also checked that the staking key didn't change.
However, this would have locked a pool with the same staking key forever. The intention is to allow the treasury administrator to change the staking address if needed.
This resolves it by moving the full address check into the Scoop redeemer path. In the Withdraw path, we require that the payment key stay fixed, but allow the staking key to be set to any allowed_staking_key from the settings datum.
Note that this required us to change the
authorized_staking_keysto a list of Credentials, so we could easily compare, though this is expected to have low impact.See: SSW-302