Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump jfmengels/elm-review-simplify from 2.1.5 to 2.1.6 in /review #169

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 13, 2025

Bumps jfmengels/elm-review-simplify from 2.1.5 to 2.1.6.

Changelog

Sourced from jfmengels/elm-review-simplify's changelog.

[2.1.6] - 2025-01-12

The rule now simplifies:

  • Set.fromList [ a, a ] to Set.fromList [ a ]
  • Set.member x (Set.singleton y) to x == y
  • Set.member x (Set.fromList [ y, x ]) to True
  • Set.member -999 (Set.fromList [ 0, 1 ]) to False
  • Dict.fromList [ a, a ] to Dict.fromList [ a ]
  • Dict.fromList [ ( a, v0 ), ( a, v1 ) ] to Dict.fromList [ ( a, v1 ) ]
  • Dict.member x [ ( y, v0 ), ( x, v1 ) ] to True
  • Dict.member -999 [ ( 0, v0 ), ( 1, v1 ) ] to False
  • List.member -999 [ 0, 1 ] to False

The rule also simplifies (thanks to [@​perkee] and [@​mfonism]):

  • List.length l == 0 to List.isEmpty l
  • List.length l /= 0 to not (List.isEmpty l)
  • ...and the same thing for Array.length, Set.size and Dict.size

Other improvements:

  • When having expectNaN enabled, we now still check expressions we know can't contain NaN like literal numbers. For example List.member 0 [ 0, 1 ] would previously not have been reported when expecting NaN, now it is.
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [jfmengels/elm-review-simplify](https://github.com/jfmengels/elm-review-simplify) from 2.1.5 to 2.1.6.
- [Changelog](https://github.com/jfmengels/elm-review-simplify/blob/main/CHANGELOG.md)
- [Commits](jfmengels/elm-review-simplify@2.1.5...2.1.6)

---
updated-dependencies:
- dependency-name: jfmengels/elm-review-simplify
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file elm Pull requests that update Elm code labels Jan 13, 2025
@dependabot dependabot bot requested review from Flo0807 and tufteddeer January 13, 2025 05:06
@Flo0807 Flo0807 merged commit e4539c0 into main Jan 13, 2025
3 checks passed
@Flo0807 Flo0807 deleted the dependabot/elm/review/jfmengels/elm-review-simplify-2.1.6 branch January 13, 2025 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file elm Pull requests that update Elm code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant