Fix field length for command packets

[Kowaman]

Updates the field length for ClientCommand and UnsingedClientCommand packets.

Resolves OverflowPacketException being thrown, I imagine this is only encountered with usage of the run_command chat click event, as players can't send a command this length in the chat bar.

https://wiki.vg/Protocol#Chat_Command

[roeii]

Change looks good. 256 might be a left over?

[Outfluencer]

please take a look into all minecraft versions

the protocol wiki is not guaranteed to be right

For the ClientCommand packet take a look into the networking for all versions that packet is registered for

[Outfluencer]

i took a look on my own

Here you can see the limit for 1.19 is 256

so you sould respect that

[Kowaman]

Thanks for looking. It looks like it was increased with PVN 766, ie 1.20.5/1.20.6 -- how should I go about handling the difference between versions?

[Outfluencer]

Use the protocolVersion argument, check the version, and use the matching value

Like this:

readString( buf, protocolVersion >= ProtocolConstants.MINECRAFT_1_20_5 ? 32767 : 256 );

[Kowaman]

Should be good now! Thanks for the tip @Outfluencer

[md-5]

Should probably be a ternary like the example Outfluencer gave in his comment

[Kowaman]

Should probably be a ternary like the example Outfluencer gave in his comment

@md-5 Sounds good -- was trying to match the existing style but if ternary is preferred can do that