Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔀 :: (#118) 인기 게시글 목록조회 api #119

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

glay415
Copy link
Member

@glay415 glay415 commented Jun 20, 2022

No description provided.

@glay415 glay415 added the 기능 추가 새로운 기능 요청을 나타냅니다. label Jun 20, 2022
@glay415 glay415 self-assigned this Jun 20, 2022
@glay415 glay415 linked an issue Jun 20, 2022 that may be closed by this pull request

List<PublicFeed> publicFeedList = publicFeedRepository
.findTop8ByCreatedAtBetweenOrderByLikeCountDesc(
LocalDateTime.now().minusDays(1), LocalDateTime.now()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now 따로 빼서 하나로 쓰는거 어때?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

굳이 할필욘 없을듯

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

안이 now 호출을 두 번 하잖어

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ㅇㅋ

return new PopularFeedListResponse(popularFeedList);
}

public PopularFeed buildPopularFeed(PublicFeed publicFeed) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

쿼리가 몇 방이야..ㄷ

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

슬픈게지

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jul 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
기능 추가 새로운 기능 요청을 나타냅니다.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

인기 게시글 목록보기 api
3 participants