SiS compatibility for SMG app #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first draft to get things running
…pdate cortex analyst msg send for oss and sis
Replace the IDE Custom Component
Fixed all libraries to current "Latest" in SiS
…nment in streamlit
sfc-gh-cnivera
commented
Oct 14, 2024
| @@ -180,7 +180,7 @@ def _get_column_representation( | |||
| cursor = conn.cursor(DictCursor) | |||
| assert cursor is not None, "Cursor is unexpectedly None" | |||
| cursor_execute = cursor.execute( | |||
| f'select distinct "{column_name}" from "{schema_name}"."{table_name}" limit {ndv}' | |||
| f'select distinct "{column_name}" from {schema_name}.{table_name} limit {ndv}' | |||
There was a problem hiding this comment.
For now we'll remove the quotes since we are fully qualifying the schema name earlier. If we want to support quote identifiers on table and column objects, let's do that as a subsequent effort.
sfc-gh-cnivera
requested review from
sfc-gh-nsehrawat,
sfc-gh-rehuang,
sfc-gh-dasilva,
sfc-gh-yayin,
sfc-gh-jsummer and
sfc-gh-twhite
as code owners
sfc-gh-jsummer
approved these changes
Oct 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparing the semantic model generator to be SiS-compatible.