fix: unable to commit with ts errors in unstaged files #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please check if I replicated the original behavior. |
FrantisekMichalSebestyen
force-pushed
the
NSNG-449-fix-be-able-to-commit-with-errors-in-unstaged-files
branch
from
ae87338 to
a5bdfea
Compare
| @@ -1,4 +1,5 @@ | |||
| #!/usr/bin/env sh | |||
| . "$(dirname -- "$0")/_/husky.sh" | |||
|
|
|||
| npm run type-check | |||
| git stash -q --keep-index && npm run type-check && git stash pop -q && npx lint-staged | |||
There was a problem hiding this comment.
In case of type-check error script wont continue and stash is never poped back
thats why I suggested to start with trap 'git stash pop -q' EXIT;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stash unstaged files before type check