Create src/folder.jl to handle serving of Folder() #280
+29
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! So I took your example from discourse and made it work for my use case. Works great! Sorry that it's in a rough state but I wanted to push this draft before the weekend to get some quick feedback, if you have time.
One of the unfortunate part is that if I serve it as
route!(server, r"/docs/.*" => Folder(joinpath(@__DIR__, "../../MyPackage/build"))), then because of thejoinpath, it will lookup/docs/index.htmlinMyPackage/build/docs/index.html(whereas I want the path to beMyPackage/build/index.html). It's kinda OK, I guess I can use a symlink to get around that, but if you have an elegant proposal I'd be happy to implement it.TODO:
Thanks!