WIP: Use index to detect test library #3031
Draft
+112
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyw8
commented
Jan 9, 2025
| @response_builder = T.let( | ||
| ResponseBuilders::CollectionResponseBuilder[Interface::CodeLens].new, | ||
| ResponseBuilders::CollectionResponseBuilder[Interface::CodeLens], | ||
| ) | ||
| super() | ||
| Listeners::CodeLens.new(@response_builder, global_state, uri, dispatcher) | ||
| Listeners::CodeLens.new(@response_builder, test_library, uri, dispatcher) | ||
|
|
||
| Addon.addons.each do |addon| | ||
| addon.create_code_lens_listener(@response_builder, uri, dispatcher) |
There was a problem hiding this comment.
@st0012 @vinistock I'm wondering how we should update this since currently ruby-lsp-rails checks @global_state.test_library == "rails". What if we make test_library be an optional keyword argument? That would prevent breaking the API for other addons.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1334
Co-authored with @st0012
TODO:
unknownvsnone?