Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent IOError occurrences in the logger thread #554

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

vinistock
Copy link
Member

@vinistock vinistock commented Jan 9, 2025

When we're shutting down the add-on, we first send a shutdown notification to the runtime server. That will make the process quit, which closes all of the standard pipes from one end.

When that happens, if the logger thread tries to execute the @stderr.gets call, it will fail with an IOError because the pipe was closed by the other end.

That doesn't actually represent any errors, since we're already shutting down the server. Let's rescue that error so that we don't keep printing unnecessary errors to the output tab.

@vinistock vinistock added the bugfix This PR fixes an existing bug label Jan 9, 2025 — with Graphite App
Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@vinistock vinistock requested review from alexcrocha and andyw8 January 9, 2025 22:05
@vinistock vinistock marked this pull request as ready for review January 9, 2025 22:07
@vinistock vinistock requested a review from a team as a code owner January 9, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This PR fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant