Set @line_number directly on the Liquid::ParseContext #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,6 +37,7 @@ void Init_liquid_c(void) | |||
| id_to_s = rb_intern("to_s"); | |||
| id_call = rb_intern("call"); | |||
| id_compile_evaluate = rb_intern("compile_evaluate"); | |||
| id_ivar_line_number = rb_intern("@line_number"); | |||
There was a problem hiding this comment.
Is there a reason id_ivar_line_number is declared in liquid.c rather than block.c? Is it/will it be used anywhere else?
There was a problem hiding this comment.
this will let me re-use the same ID for re-using with
rb_attr_get, which I will need for Liquid::Assign.compile in #96
peterzhu2118
approved these changes
Oct 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Liquid::ParseContextuses anattr_accessorfor the line number. Right now liquid-c is callingLiquid::ParseContext#line_number=to set that attribute, but it would be faster to just callrb_ivar_set. Also, this will let me re-use the same ID for re-using withrb_attr_get, which I will need for Liquid::Assign.compile in #96