Add sanity check to InlineVerifier and TargetVerifier #261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lincoln23
force-pushed
the
add-row-verified-check
branch
7 times, most recently
from
3750b1c to
d131335
Compare
Lincoln23
changed the title
Lincoln23
force-pushed
the
add-row-verified-check
branch
from
d131335 to
34bc990
Compare
Lincoln23
force-pushed
the
add-row-verified-check
branch
from
34bc990 to
5d96861
Compare
Lincoln23
commented
Feb 24, 2021
| @@ -68,7 +68,7 @@ def test_different_compressed_data_is_detected_inline_with_batch_writer | |||
|
|
|||
| assert verification_ran | |||
| assert_equal ["#{DEFAULT_DB}.#{DEFAULT_TABLE}"], incorrect_tables | |||
| assert_equal "cutover verification failed for: gftest.test_table_1 [paginationKeys: 1 ] ", ghostferry.error_lines.last["msg"] | |||
| assert_equal "cutover verification failed for: gftest.test_table_1 [paginationKeys: 1 ] ", ghostferry.error_lines.first["msg"] | |||
There was a problem hiding this comment.
These tests will log target verifier did not check any events since there are no events on the target. I added a separate test to check target verifier events below so I will ignore that error here
Same changes for tests below
Lincoln23
commented
Feb 24, 2021
Comment on lines
+439
to
+444
| if v.rowsChecked == 0 { | ||
| return VerificationResult{ | ||
| DataCorrect: false, | ||
| Message: "cutover verification failed, no rows were compared", | ||
| }, nil | ||
| } |
There was a problem hiding this comment.
I wasn't sure how to test this in the ruby integration tests since in integrationferry here we only pass the incorrect tables. perhaps we pass the message as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#263
For InlineVerifier:
check if
rowsChecked > 0when we runVerifyDuringCutover.if no rows were checked, return
VerificationResult.DataCorrect = FalseFor TargetVerifier:
check after we run
StopTargetVerifierto see if we verified any eventsif no events were checked, we log and return an error, copydb and sharding will then panic