Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes the fuzzydate function more restrictive. The changes are:
For dates without a month name, only dates with two valid separators(
/
-
.
) are allowed.ex.
1/2
is no longer assumed to be a date where as1/2/0
is acceptable.dates with spaces as a separator are not assumed to be dates such as
1 2 0
Note:
1 / 2 / 0
is acceptableAlso fixes
AUD 76.09
from a comment on issue [0.15.1] Text being converted to dates #1636 will no longer be parsed as a date.Values such as
05.030.2713
will no longer be accepted as dates because of the month having 3 digits (a total of > 10 digits) problem with numeric formatting with CSV file. #2485I have seen many issues created over fuzzydate and while raw parsing is a workaround, many people want other numeric values preserved and by default. This is a proposed solution by dropping support for mm/dd, mm/yyyy, mm.yyyy etc.
I assume support for dates with a space separator is necessary so let me know if it's worth continuing in this direction. An issue not addressed by this solution is the automatic date conversion of values with two decimal points such as:
3.5.2
. Values like these are often used for software versioning. I would prefer not to have to use decimal separator with dates as it's much less common but was curious if any other spreadsheet software uses this standard.