Knob board rev a pcb #214
Open
Knob board rev a pcb #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I fixed a trace error involving C3, added a REVxxxxx label to silkscreen, shortened the board size to 80mm x 70mm, added the board outline to the mechanical 1 layer, added the Severson Group PNG to the silkscreen., and changed the following rules. Electrical Clearance (Minimum Clearance) = 0.16mm. Maximum hole dimensions = 5mm. Silk to solder mask clearance = 0.1mm. The former two rules were taken from the AMDC pcb rules. The final rule, is based on Robert Feranec's Altium tutorial. With these altered rules, this design passes the Design Rule Check without errors.
Updated SPI's on CON1 and CON2.
npetersen2
requested changes
Apr 27, 2022
There was a problem hiding this comment.
Looking great, @wknutson ! I think the PCB layout is ready to go for ordering.
However, can you clean up the files and folders in the repo to match the other board designs?
- Change the top level folder for your board to be consistent with your schematic PR. Stick with
ExpansionBoard_Knob/ - Add a
.gitignoreto remove theHistory/and__Previews/folder - Generate the gerber files and put them in the
gerbers/folder - Move all the image files to a
images/folder and update the links in Altium accordingly - Remove the
Extra Stuff/folder; if the things inside are needed, put them in clearly named folders according to the repo guidelines in the Severson-Group KB doc
Closed
elsevers
requested changes
Apr 27, 2022
Changed the top level folder name, deleted the Extra Stuff directory, added a .gitignore.txt file (we will see if it works), moved currently used images into Images directory (image based graphics on the PCB still appear), added a 0 in front of .1uF in the schematic, ensured there are no polygon pour islands, added more space between some of the surface mounted parts, hid the C4 part numbers on the schematic, and removed a C4 SPI. This still passes Altium's Design Rule Verification with 0 errors.
Added 1 output job file in the ExpansionBoard_Knob directory, and gerber files inside the "AMDC-Hardware\Accessories\ExpansionBoard_Knob\Project Outputs for Free Documents" directory. Nothing else was changed.
npetersen2
requested changes
May 2, 2022
There was a problem hiding this comment.
- Change the
.1uFvalues in the schematic to0.1uFfor all the capacitors - Remove the
History/folder from git. You added the.gitignorebut since you already had added the files, see this post for how to fix: https://stackoverflow.com/a/34435207 - Remove the
Project Outputs ...folders; if they have things in them of value (like the gerbers), move them elsewhere - Remove
PCB_Review.pdf - Remove
Schematic_Review.pdf
In general, please follow the KB guidelines to get the files changed in this PR to be appropriate--you should not be trying to merge 196 file changes!!
See other group boards for examples, e.g.: https://github.com/Severson-Group/AMDC-Hardware/tree/develop/Accessories/TestBoard
Removed the Project Outputs folder and rearranged it's files to match standards. Removed the extra .pdf files made for presenting, and removed the History and _Previews directories (They will be back in the next commit). Also changed .1uF values to 0.1uF in Altium. Finally, gerber files are now working, although there are likely an excess of unnecessary gerber files.
I corrected the .gitignore file. This should allow uploads of the _Previews and History directories without showing changes in those folders.
npetersen2
requested changes
May 4, 2022
There was a problem hiding this comment.
@wknutson Looking better, see my inline comment below.
I updated the gerber files and removed the unneeded ones. I placed the order for the board blanks. Once you update the BOM, I will order the parts.
Accessories/ExpansionBoard_Knob/REV20220427A/BOM_Encoder_Expansion_Board_Project.csv
Outdated
Show resolved
Hide resolved
|
Another request: we need a top-level README file describing your board, and a README file in the Please see the other boards in this repo for examples. |
Updated the BOM .csv and .xlsx files in the REV20220427A directory.
The README file located in "AMDC-Hardware\Accessories\ExpansionBoard_Knob\REV20220427A". This README is likely complete, however some of the links may need to be updated. The image links are also set to work once the files are merged into the develop branch, but don't currently work. The second README is located in "GitHub\AMDC-Hardware\Accessories\ExpansionBoard_Knob\REV20220427A". This README has a couple of unfilled inputs that I need to update later.
Updated the README file in "AMDC-Hardware\Accessories\ExpansionBoard_Knob\REV20220427A"
I added the BackPage.SchDoc with images of additional parts. I also created Knob_Expansion_Board_Schematics.pdf which is a .pdf file of the schematic files. Not sure if images in BackPage.SchDoc are actually imbedded into Altium. I think it is unlikely, but will commit this for now. The WEMPEC template has also been added because it is an important Altium file that I can difficulty finding elsewhere. It is not crucial though, and can be removed.
I added a low pass filter .svg file. This file doesn't belong in this repository, however I will upload it so it can be transferred to the docs.amdc.dev website at a later date. The BOM also had an error, where the sig dif part listed was incorrect.
I created Knob_Expansion_Board.md. This should also not belong in this repository, however, I am uploading it for demonstration purposes in addition to creating a copy to transfer to docs.amdc.dev at a later date.
Fixed typos in all 3 markdown files.
Fixed more typos in Knob_Expansion_Board.md
I connected the Mounting Holes to GND on the PCB and added the corresponding schematic on the schematic backpage.
Updated knob board schematic PDF to include the updated BackPage.SchDoc
Removed and implemented the files from the Final Documentation directory into the docs.amdc.dev repository.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encoder Board Information
BOARD SIZE = 70mm x 80mm
Layers = 2
Unique Parts = 9
Cost per Board (Unit 1) = $8.64
Cost per Board (Unit 10) = $7.17
More information is given in the attached PCB .pdf files.