-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/freertos singlecore #407
base: v2-staging
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @Known4225 !
Before we try to review this PR, can you work on reducing the amount of files changed a bit? For example, it looks like you deleted everything..? then added some stuff back.
Can you try to do one of these things? 1) explain what you did so we can follow the story better; 2) put back changed files that you don't need to change; 3) make multiple PRs which make these full changes in smaller sets so we can easily review them
Hi @Known4225 , per our conversation yesterday, please try to do the following:
Keep in mind, to get the CLI working, i.e., |
I have gotten the command system up and running with FreeRTOS.
List of changes/features:
Notable absences:
It's a little bit "quick and dirty" as I went through and just commented out anything to do with icc in the commands source file. It's more of a "now it works" than a "this is the correct way to do it". Luckily the structure of the apps have only minor changes (FreeRTOS task handles, loops instead of callback functions, etc).
I think next steps are getting ethernet working, moving over the rest of the drv files, and (maybe) enabling icc stuff for the commands (to put them on par with the v1.2 implementation). Though the icc system is something of a mystery to me currently.
I have also not tested the hardware commands with the real world!