-
-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[dotnet] Tolerate invalid UTF-16 strings in DevTools JSON response #14972
[dotnet] Tolerate invalid UTF-16 strings in DevTools JSON response #14972
Conversation
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
Repro test: [Test]
public void AAA()
{
driver.Manage().Network.StartMonitoring().GetAwaiter().GetResult(); // this enables serialization
driver.Navigate().GoToUrl("https://tus.io/demo");
Thread.Sleep(10_000);
driver.FindElement(By.Id("P0-0")).SendKeys("C:\\Users\\Nick\\Downloads\\Firefox Installer.exe");
Thread.Sleep(60_000);
} Passes both on Firefox and Chrome. |
third_party/dotnet/devtools/src/generator/Templates/DevToolsSessionDomains.hbs
Outdated
Show resolved
Hide resolved
…olsSessionDomains`
…el/selenium into devtools-file-upload
Co-authored-by: Nikolay Borisenko <[email protected]>
That's my bad for forgetting the file header. Fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @RenderMichael !
User description
Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it
Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.
Description
This restores Newtonsoft behavior of tolerating invalid UTF-16 strings.
Motivation and Context
Fixes #14903
Types of changes
Checklist