Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

K8s deployment #1825

Open
wants to merge 35 commits into
base: main
Choose a base branch
from

Conversation

rajangoswamiTWS
Copy link
Contributor

@rajangoswamiTWS rajangoswamiTWS commented Jan 14, 2025

Important

Add Kubernetes deployment configurations for R2R development environment including ArgoCD, PostgreSQL, R2R, R2R Dashboard, and Unstructured components.

  • ArgoCD Configuration:
    • Adds dev-autosync.yaml for ArgoCD application setup targeting r2r-dev namespace with automated sync policy.
  • Namespace:
    • Creates namespace.yaml to define r2r-dev namespace.
  • PostgreSQL:
    • Adds pg.yaml for PostgreSQL Secret, ConfigMap, Deployment, and Service in r2r-dev namespace.
    • Configures PostgreSQL with 1 replica and persistent volume claim postgres-pvc.
  • Persistent Volumes:
    • Adds pv.yaml for postgres-pvc and pvc-r2r-config-blob with specific storage requests.
  • R2R Application:
    • Adds r2r.yaml for R2R ConfigMap, Deployment, and Service with 4 replicas and health probes.
  • R2R Dashboard:
    • Adds r2r-dashboard.yaml for R2R Dashboard Deployment and Service with 1 replica and load balancer.
  • Unstructured Component:
    • Adds unstructured.yaml for Unstructured Deployment and Service with 4 replicas.
  • Secrets:
    • Adds secret.yaml for R2R application secrets including PostgreSQL credentials and Azure API key.

This description was created by Ellipsis for df79309. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to fecffa3 in 58 seconds

More details
  • Looked at 392 lines of code in 8 files
  • Skipped 1 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. py/k8s/dev/azure/pg.yaml:10
  • Draft comment:
    The base64 encoded values for POSTGRES_USER and POSTGRES_PASSWORD are identical. This is a security risk. Ensure that the password is unique and securely managed.
  • Reason this comment was not posted:
    Comment did not seem useful.
2. py/k8s/dev/azure/secret.yaml:10
  • Draft comment:
    The base64 encoded values for R2R_POSTGRES_USER and R2R_POSTGRES_PASSWORD are identical. This is a security risk. Ensure that the password is unique and securely managed.
  • Reason this comment was not posted:
    Marked as duplicate.
3. py/k8s/dev/azure/namespace.yaml:7
  • Draft comment:
    The label name: r2r-dev is redundant and can be removed to avoid confusion, as the namespace name is already specified.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The label name is redundant in the namespace definition and can be removed.
4. py/k8s/dev/azure/r2r-dashboard.yaml:1
  • Draft comment:
    The comment # Deployment and Service for Unstructured is incorrect. Update it to reflect the correct content, such as # Deployment and Service for R2R Dashboard.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The comment at the top of the file is incorrect and should be updated to reflect the correct content of the file.

Workflow ID: wflow_kVeIgyi0ppkss6LI


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

py/k8s/dev/azure/secret.yaml Outdated Show resolved Hide resolved
@rajangoswamiTWS
Copy link
Contributor Author

@ellipsis review this

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to df79309 in 57 seconds

More details
  • Looked at 392 lines of code in 8 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. py/k8s/dev/azure/secret.yaml:10
  • Draft comment:
    Avoid hardcoding sensitive data like passwords in the YAML files, even if they are base64 encoded. Consider using a more secure method to manage secrets, such as using a secrets management tool or environment variables.
  • Reason this comment was not posted:
    Marked as duplicate.
2. py/k8s/dev/azure/secret.yaml:12
  • Draft comment:
    Avoid hardcoding sensitive data like API keys in the YAML files, even if they are base64 encoded. Consider using a more secure method to manage secrets, such as using a secrets management tool or environment variables.
  • Reason this comment was not posted:
    Marked as duplicate.
3. py/k8s/dev/azure/pg.yaml:37
  • Draft comment:
    Consider increasing the number of replicas for the PostgreSQL deployment if high availability or load balancing is required.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The deployment configuration for the PostgreSQL service uses a single replica, which might not be sufficient for high availability or load balancing. Consider increasing the number of replicas if needed.
4. py/k8s/dev/azure/unstructured.yaml:9
  • Draft comment:
    Ensure that the number of replicas for the "unstructured" deployment is appropriate for the expected load and resource availability.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The deployment configuration for the "unstructured" service uses 4 replicas, which might be more than necessary depending on the load. Ensure that this number is appropriate for the expected load and resource availability.

Workflow ID: wflow_MQrpD2quOoWFal5j


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

py/k8s/dev/azure/pg.yaml Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant